search

GPlates / gplately

GPlately is a Python package to interrogate tectonic plate reconstructions.
https://gplates.github.io/gplately/
GNU General Public License v2.0
55 stars 11 forks source link

refactor large source files? #169

Open michaelchin opened 3 months ago

michaelchin commented 3 months ago

Some of the source files are growing too large(thousands of lines). Maybe consider to divide them into small files and add sub-folder when necessary. consider, discuss and decide

cpalfonso commented 1 month ago

I came up with some improvements to the subduction teeth functions a while ago (such as specifying tooth size/spacing in points rather than projected units, as well as recalculating and redrawing the teeth when the extent of the plot changes) which involved some fairly extensive changes to the gplately.plot module, so I could have a look at breaking up that file when I implement those changes.

michaelchin commented 1 month ago

I came up with some improvements to the subduction teeth functions a while ago (such as specifying tooth size/spacing in points rather than projected units, as well as recalculating and redrawing the teeth when the extent of the plot changes) which involved some fairly extensive changes to the gplately.plot module, so I could have a look at breaking up that file when I implement those changes.

Thanks, but no need to worry about it. I will take care of that.

michaelchin commented 4 weeks ago

I came up with some improvements to the subduction teeth functions a while ago (such as specifying tooth size/spacing in points rather than projected units, as well as recalculating and redrawing the teeth when the extent of the plot changes) which involved some fairly extensive changes to the gplately.plot module, so I could have a look at breaking up that file when I implement those changes.

Hi @cpalfonso

just out of curiosity, are you coming back to work on gplately? What's the plan?

@brmather

michaelchin commented 2 weeks ago

New pygplates will be released soon. The new GPlately release will follow soon. It is not a good time to refactor or touch working code. Put this issue on ice.