search

GPlates / gplately

GPlately is a Python package to interrogate tectonic plate reconstructions.
https://gplates.github.io/gplately/
GNU General Public License v2.0
56 stars 13 forks source link

Is this a bug? #174

Closed michaelchin closed 4 months ago

michaelchin commented 5 months ago

@brmather @lauren-ilano @jcannon-gplates See the code below. The 'continue' statement will skip the current loop iteration. The current point will not be reconstructed. But according to the comments, it should be reconstructed. https://github.com/GPlates/gplately/blob/f49b31695882df362fda45f7ad7fcc5bf5c7d68e/gplately/reconstruction.py#L2563-L2570

jcannon-gplates commented 4 months ago

Yeah I think that's a bug. Good spot! I think that's been in there since the beginning. Removing continue should fix it, I think.

On a related note, as mentioned in #101, at some stage all that code can get replaced (since it's now in pyGPlates). For example, I recently did a similar thing for the Predicting Sediment Thickness workflow by changing this to this.

michaelchin commented 4 months ago

Yeah I think that's a bug. Good spot! I think that's been in there since the beginning. Removing continue should fix it, I think.

On a related note, as mentioned in #101, at some stage all that code can get replaced (since it's now in pyGPlates). For example, I recently did a similar thing for the Predicting Sediment Thickness workflow by changing this to this.

Thanks John.

I will remove the "continue" and do some tests.

michaelchin commented 4 months ago

fixed in e7112cac760e3317e312d6c89a30392f61c8fee7