search

GPlates / gplately

GPlately is a Python package to interrogate tectonic plate reconstructions.
https://gplates.github.io/gplately/
GNU General Public License v2.0
60 stars 13 forks source link

various issues with gplately #256

Closed michaelchin closed 3 months ago

michaelchin commented 3 months ago

These issues were reported by HS. Need triage first.

_check the screenshot in the shared folder named 'Movie_GplatelyPython.' For instance, at 1800 Ma, the subduction teeth are visible in a weird way, and around 1200 Ma, despite having a PlateID, aren't moving.

_It's strange because everything seems fine when using the GPlates software, as seen in the folder named 'Movie_GplateSoftware.'

michaelchin commented 3 months ago

This may be related to https://github.com/GPlates/gplately/issues/191

Screenshot 2024-08-15 at 2 24 12 PM
michaelchin commented 3 months ago
Screenshot 2024-08-15 at 2 51 38 PM Screenshot 2024-08-15 at 2 52 07 PM
michaelchin commented 3 months ago

I opened the data file in GPlates and saw more points than in the screenshots above. Not sure which points are the problem. Need more info from clients.

Screenshot 2024-08-15 at 2 59 29 PM
michaelchin commented 3 months ago

after triage, this issue should be split into small, actionable issues. This issue may contain multiple problems and the description for these problems are very unclear.

michaelchin commented 3 months ago

thumbnail_Rift_Deposits_1020

michaelchin commented 3 months ago

@Hojat-Shirmard

These points do not move after around 1000 Ma.

According to description above, it is very likely that the plate ID has no rotation definition after 1000Ma. See an example in the screenshot below.

Screenshot 2024-08-15 at 4 35 41 PM
michaelchin commented 3 months ago

If the plate ID is 16107. It will stop moving at 610Ma in the "1.8G model".

michaelchin commented 3 months ago

It is very likely that the points were not moving is not a gplately problem. Waiting for HS to confirm.

Hojat-Shirmard commented 3 months ago

Give me some time to write a script that tracks the points over time to identify those that don't move.

Cheers, Hojat

From: michaelchin @.> Sent: Thursday, August 15, 2024 5:19 PM To: GPlates/gplately @.> Cc: Hojat Shirmard @.>; Mention @.> Subject: Re: [GPlates/gplately] various issues with gplately (Issue #256)

If the plate ID is 16107. It will stop moving at 610Ma in the "1.8G model".

— Reply to this email directly, view it on GitHubhttps://github.com/GPlates/gplately/issues/256#issuecomment-2290802375, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHKSJU4ZA5CQU5FXIK7WG3LZRRI7VAVCNFSM6AAAAABMRRGX56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQHAYDEMZXGU. You are receiving this because you were mentioned.Message ID: @.***>

michaelchin commented 3 months ago

You can just compare the coordinates before and after reconstruction. If the rotation is not defined at some age, the coordinates should be the same. It is very likely the rotation is undefined for the plate i d beyond a certain age.

michaelchin commented 3 months ago

According to HS' email, it seemed that the "points not moving" was not a gplately bug at all.

Now the only remaining problem in this issue is the plate boundary plotting problem. It might be related to #191. I have asked HS to try the code change in the "191-plotting-artefacts-in-orthographic-projection" branch to see if it has the same root cause.

Once confirmed, this issue can be closed as duplicate.

michaelchin commented 3 months ago

@Hojat-Shirmard

Checkout "191-plotting-artefacts-in-orthographic-projection" branch and install gplately from the source code. See the instructions in the link below.

https://github.com/GPlates/gplately?tab=readme-ov-file#2-using-pip

Hojat-Shirmard commented 3 months ago

Yes, sure. Many thanks!

Cheers, Hojat

From: michaelchin @.> Sent: Monday, August 19, 2024 3:55 PM To: GPlates/gplately @.> Cc: Hojat Shirmard @.>; Mention @.> Subject: Re: [GPlates/gplately] various issues with gplately (Issue #256)

@Hojat-Shirmardhttps://github.com/Hojat-Shirmard

Checkout "191-plotting-artefacts-in-orthographic-projection" branch and install gplately from the source code. See the instructions in the link below.

https://github.com/GPlates/gplately?tab=readme-ov-file#2-using-pip

— Reply to this email directly, view it on GitHubhttps://github.com/GPlates/gplately/issues/256#issuecomment-2295724548, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHKSJU2SZHJ2YEYTMV2WVWLZSGCGTAVCNFSM6AAAAABMRRGX56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVG4ZDINJUHA. You are receiving this because you were mentioned.Message ID: @.***>

michaelchin commented 3 months ago

Have #161 and #160 fixed the "subduction teeth" problem? Can I close this issue?

Hojat-Shirmard commented 3 months ago

Not yet!

From: michaelchin @.> Sent: Friday, August 23, 2024 4:37 PM To: GPlates/gplately @.> Cc: Hojat Shirmard @.>; Mention @.> Subject: Re: [GPlates/gplately] various issues with gplately (Issue #256)

Have #161https://github.com/GPlates/gplately/pull/161 and #160https://github.com/GPlates/gplately/pull/160 fixed the "subduction teeth" problem? Can I close this issue?

— Reply to this email directly, view it on GitHubhttps://github.com/GPlates/gplately/issues/256#issuecomment-2306392235, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHKSJU24SONK4W3AW7KLOGDZS3KBBAVCNFSM6AAAAABMRRGX56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGM4TEMRTGU. You are receiving this because you were mentioned.Message ID: @.***>

michaelchin commented 3 months ago

Can I close this issue now?

Hojat-Shirmard commented 3 months ago

Yes sure. Thank you again!

On Tue, Aug 27, 2024, 6:32 PM michaelchin @.***> wrote:

Can I close this issue now?

— Reply to this email directly, view it on GitHub https://github.com/GPlates/gplately/issues/256#issuecomment-2311895033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHKSJU7F7Z6P5OE2ARB35MLZTQ2SHAVCNFSM6AAAAABMRRGX56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJRHA4TKMBTGM . You are receiving this because you were mentioned.Message ID: @.***>