search

GPlates / gplately

GPlately is a Python package to interrogate tectonic plate reconstructions.
https://gplates.github.io/gplately/
GNU General Public License v2.0
60 stars 13 forks source link

Incorrect Column Name in tessellate_subduction_zones Function #270

Open singhsatyampratap opened 2 months ago

singhsatyampratap commented 2 months ago

Description:

In the PlateReconstruction.tessellate_subduction_zones(return_geodataframe=True) function, the returned DataFrame includes a column named overriding_plate_id. However, this column should be named trench_plate_id to accurately reflect the data it represents. The current overriding_plate_id values differ significantly from the trench plate IDs, as shown in the attached figure.

Steps to Reproduce:

  1. Use the PlateReconstruction.tessellate_subduction_zones(return_geodataframe=True) function.
  2. Inspect the returned DataFrame.

Please refer to the attached figure for a visual comparison of the overriding_plate_id and trench_plate_id.

Attachment: Trench_Plate_ID

jcannon-gplates commented 2 months ago

Yes, that's true, it probably should be changed to "trench plate ID" here. I don't think that'll cause a problem - if I don't hear from any @GPlates/gplately-dev then I'll change that next week.

Originally the subduction convergence script (previously in PlateTectonicTools) used to find the plate ID of the overriding plate, but was subsequently changed to the plate ID of the trench line for this reason.