search

GPlates / gplates-app

GPlates Mobile App
https://www.gplates.org
2 stars 0 forks source link

Settings menu broken for iOS #17

Closed matthew-merkas closed 2 years ago

matthew-merkas commented 2 years ago

No idea why this happens, or why Android is unaffected

Screen Shot 2022-05-15 at 20 25 13

michaelchin commented 2 years ago

@yiyanw It is most likely the CSS problem on iOS. You may want to wait for Maria to find a Mac computer for you.

michaelchin commented 2 years ago

@yiyanw I am not 100% sure. But can you check these code https://github.com/GPlates/gplates-app/blob/64556bb122c23d3ae6ee0b5901d8ac1f3a9fc90e/src/pages/SettingMenuPage.tsx#L45-L79

Maybe we should not enclose it in a iontoolbar.

yiyanw commented 2 years ago

Thanks, I will handle this after the Mac computer is ready. @michaelchin @matthewmerkas

matthew-merkas commented 2 years ago

Oh, @michaelchin @yiyanw I didn't see this on an actual device, but with the device toolbar in dev tools image Just change the device to an iOS device and refresh the page and you should see it

yiyanw commented 2 years ago

@michaelchin you are correct, ios do not support flexbox CSS. I will change it.

michaelchin commented 2 years ago

Oh, @michaelchin @yiyanw I didn't see this on an actual device, but with the device toolbar in dev tools

Thanks Matthew. I saw the problem in iOS simulator as well. It is yiyan's code. He will handle it.