search

GPlates / gplates-app

GPlates Mobile App
https://www.gplates.org
2 stars 0 forks source link

Add an animation settings button next to the playback buttons #22

Closed michaelchin closed 2 years ago

michaelchin commented 2 years ago

Looks great to me! Not sure how it looks on a device but might need to make the icons/text all a little larger (I'm sure it can be figured out later though).

If there is extra space (e.g. next to the icons on the top right) and doesn't make the UI messy, would it be worth considering adding some of the 'animation' settings I mentioned in #8 here too? E.g. a 'flip' button for reversing the animation, or a way to set min/max times at either end of the slider (this might look a bit messy but not sure)?

Or could go further and have all animation settings all controlled from something that opens up when you've got the time slider open - e.g. button with the three dots/lines (on top right, next to the playback buttons), and that then goes directly to changing other options such as time increment (if possible), playback speed, etc.

No clue how it would look or if it would be too messy on a phone, but maybe it would be more intuitive for students to change some of the animation parameters here than going into a separate settings menu. Something to think about at least.

Originally posted by @nickywright in https://github.com/GPlates/gplates-app/issues/1#issuecomment-1128359499

michaelchin commented 2 years ago

@nickywright @matthewmerkas This sounds a good idea. Let's discuss it in this new issue.

michaelchin commented 2 years ago

See Nicky's comments in issue https://github.com/GPlates/gplates-app/issues/8#issuecomment-1120648666

michaelchin commented 2 years ago

Ideally, when the button is pressed, the app's setting widget pops up with "animation section" highlighted/focused. The animation settings should be a part of the app's "setting widget".

matthew-merkas commented 2 years ago

Just a little video of my work so far. Let me know what you think. I decided not to include the playback section of the Configure Animations window from GPlates proper, since you can access those controls by closing the settings dialog.

https://user-images.githubusercontent.com/101497645/169704546-8b226d08-953d-43c2-9c28-a78f554f44ac.mp4

matthew-merkas commented 2 years ago

It's my understanding that different models have different year ranges (e.g. 250-0Ma, 1000-0Ma). Will we be validating inputs against these different ranges? Are we far enough along to have access to those models or is that a future problem?

matthew-merkas commented 2 years ago

Also, another thing I've just noticed, should the sliders be reversed i.e., start high (e.g., 1000Ma) and end at 0, or are they fine the way they are?

nickywright commented 2 years ago

This is awesome!

In the range options, the increment part should be 'Myr per frame' (not 'M per frame')

Also, another thing I've just noticed, should the sliders be reversed i.e., start high (e.g., 1000Ma) and end at 0, or are they fine the way they are?

Yep, sliders should start with the higher number and end at 0 Ma as the default behaviour.

matthew-merkas commented 2 years ago

Okay, I've fixed the increment typo and reversed the sliders in #45

What should I work on next @michaelchin?

michaelchin commented 2 years ago

Okay, I've fixed the increment typo and reversed the sliders in #45

What should I work on next @michaelchin?

Thanks @matthewmerkas . The progress is really good. Well done! I will assign you all the animation related issues. The animation functionalities are very important and sometimes quite tricky. Could you please work closely with @nickywright on these new features? I will provide more suggestive info in the relevant Issues. Thanks a lot.

michaelchin commented 2 years ago

It's my understanding that different models have different year ranges (e.g. 250-0Ma, 1000-0Ma). Will we be validating inputs against these different ranges? Are we far enough along to have access to those models or is that a future problem?

You are right. Each reconstruction model has its own time range. Each raster is connected to a specific reconstruction model. Eventually the info about the reconstruction models should be retrieved from a server, but for now, let's just hardcode the ranges for development purpose. The users should not be allowed to type in a time which is out of the model's time range.

michaelchin commented 2 years ago

I think this issue has been completed. The other related requirements can be dealt with in other Issues. So, close this one.