First pull request for project 1 (task 1,2 and 3)

GQCG-edu / bootcamp

The Bootcamp of the Ghent Quantum Chemistry Group, aimed at achieving the initial competences needed in order to be able to contribute to our electronic structure method development group.

GNU General Public License v3.0

1 stars 9 forks source link

First pull request for project 1 (task 1,2 and 3) #16

Closed MFatjano closed 3 years ago

xdvriend commented 4 years ago

I see now that you have created a PR from the forked repository to the `bootcamp' repository on GQCG-edu. This is something that should be avoided.

The workflow we envisioned was:

fork the bootcamp repository
create branches and PR's on the forked repository
keep us up to date with issues on either this repo or your personal one

By the end you should then have your own version of this repository, containing the three solved projects and a report on them written in LaTeX. If you have any questions on how to set any of this up, don't hesitate to contact me! This is all closely linked with issue #18 so I'l try to keep track of this as closely as possible until everything is resolved.

xdvriend commented 4 years ago

You mentioned in issue #18 that you are stuck at step 7, but your PR only goes up to step 3 at the moment. Don't be afraid to commit and push things that aren't 100% correct yet! We encourage you to commit and push as often as possible, as this helps us to track your progress.

If a PR is created for a work in progress, GitHub allows you to create a Draft Pull Request instead. This shows that you are still working on that PR. Once it is finished, you can the open it for review.

MFatjano commented 4 years ago

@xdvriend Okay that's clear! I'll keep that all in mind in my next pull request. I will also add you all to my forked repository!

xdvriend commented 3 years ago

@MFatjano, since you have pushed all these changes to your own personal repository as well, I will close this PR.