PR with Issue #31 - Githubissues

GQCG-edu / bootcamp

The Bootcamp of the Ghent Quantum Chemistry Group, aimed at achieving the initial competences needed in order to be able to contribute to our electronic structure method development group.

GNU General Public License v3.0

1 stars 9 forks source link

PR with Issue #31 #32

Closed ruvdrsti closed 3 years ago

ruvdrsti commented 3 years ago

@guacke @dariatols @xdvriend This could be an application of my idea from issue #31. Mind you, the file now only contains the lines of code @MFatjano sent me to help me remember how to connect to the HPC and some random error I encountered. The idea would be that when some technical inconvenience pops up that seems rather tedious to solve, it would be added to this file. Its goal then would be to help fix technical issues quickly, so that more time remains for the actual project you are working on, be it studying the subjects of the bootcamp or something else entirely.

xdvriend commented 3 years ago

A couple of remarks:

There is no need to upload your code_workspace file, as this contains personal VSCode settings. So could you remove that from this PR?
When typing code in markdown you can actually create code blocks. For example:

qsub -I -l nodes=1:ppn=3

instead of

qsub -I -l nodes=1:ppn=3

So if you make these adjustments, add me as a reviewer & I'll approve this PR for you. I would also like to mention: great initiative to add this information to the bootcamp! It shows that you get what the group dynamic in GQCG is all about.

ruvdrsti commented 3 years ago

All the requested changes have been made. Thanks for your support!

ruvdrsti commented 3 years ago

@xdvriend @dariatols I added a file that @MFatjano (thanks again, by the way) sent me over the weekend. Given that it is more complete, I would suggest using it instead of the first file.

dariavh commented 3 years ago

@ruvdrsti Thanks for your elaborated guide for Windows users! In the last two commits, I've made some adjustments to make the files more in accordance with other .md files generated by GQCG. When writing code blocks, try to use "`...`" instead of <code>...<\code>.

Another tip would be to use keywords in your commits/PRs. This way, you can link PRs to issues and automatically close them when the PR is merged.

guacke commented 3 years ago

@ruvdrsti Can you merge this pull request as @dariatols has approved it?

ruvdrsti commented 3 years ago

I wasn't sure I was allowed to merge into the "official" branch. Will do so right away.

guacke commented 3 years ago

@ruvdrsti and @xwieme I have added 'branch protection rules' which codify our workflow: once a fellow member has reviewed and approved your work, you get the honour of merging your branch with master. Good work @ruvdrsti !