search

GR3YH4TT3R93 / zellij-nav.nvim

a Neovim plugin to help navigate betweeen Zellij panes as well as create new ones!
GNU General Public License v3.0
8 stars 1 forks source link

feat: add support for toggle-floating-panes action #4

Open JonnyLoughlin opened 1 month ago

JonnyLoughlin commented 1 month ago

Added support for a command I use frequently plus a user command and its default keybinding.

JonnyLoughlin commented 1 month ago

Forgot to update the README, will fix

JonnyLoughlin commented 1 month ago

This needs additional work. The locking doesn't toggle properly with floating panes. I will fix this up

GR3YH4TT3R93 commented 1 month ago

Looks good other than the README has an issue with keybinds (A-t rather than A-f) and there's a typo in mappings.lua (ToggleFloatingPanges rather than ToggleFloatingPanes). Once those are fixed, I'd be happy to merge!

JonnyLoughlin commented 1 month ago

Thanks for catching that!

After some more testing, zellij-autolock doesn't seem to be functioning correctly with floating panes. I'm not very versed with Rust but I will take a look to see if I can figure out why, and, I'll file an issue over there.

I will fix the README but I still think this PR should wait to be merged until after I can figure this out since it may cause confusion if it isn't working properly.