search

GRA0007 / Blue

A mod of Scratch 2.0 by MIT
https://scratch.mit.edu/discuss/topic/51366/
GNU General Public License v2.0
16 stars 8 forks source link

Stack Inputs On Custom Blocks #16

Open ckissane opened 8 years ago

ckissane commented 8 years ago

:)

NoMod-Programming commented 8 years ago

The new custom blocks look great, and the variable colors/set x and y blocks perform very well! A few minor tweaks are needed in the UI, though, so maybe you can create a new pull request with just the new blocks right now, that way we can import them, and have a seperate PR for the UI?

Honestly, I'm loving the new UI, but it feels a bit "hacked" together at this moment. For example, the tabs, at the first glance, look kind of thrown on hastily, and gray-ish colors in the ScriptsPane and other parts of the UI stand out too much. Also, a faint, 1px blue line appears between the stage and the library. The buttons in the ScriptsPane are in need of a faint outline, too, to give the user a general area to click on, even if it's just when it's hovered over (like Google does). Other than the couple of minor tweaks needed to make this UI fit in, I think this is almost ready to go!

@GRA0007, any thoughts on this?

NoMod-Programming commented 8 years ago

Also, the diff says that every line of code was changed. A github issue? EDIT: It's because of line endings. EDIT 2: Nope. It was file permissions

ckissane commented 8 years ago

Thats likely a github issue. Oh and I will make some more changes to make it fit in :).

On Fri, Sep 30, 2016 at 10:50 AM, Edward P. notifications@github.com wrote:

Also, the diff says that every line of code was changed. A github issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GRA0007/Blue/pull/16#issuecomment-250809077, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKYesO4-lxNBwd-Jwbwps7ppcxrxLPfks5qvUv8gaJpZM4KDcad .

ckissane commented 8 years ago

I made some already and can update my github if you want.

On Fri, Sep 30, 2016 at 10:44 PM, C L K Kissane coler706@gmail.com wrote:

Thats likely a github issue. Oh and I will make some more changes to make it fit in :).

On Fri, Sep 30, 2016 at 10:50 AM, Edward P. notifications@github.com wrote:

Also, the diff says that every line of code was changed. A github issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GRA0007/Blue/pull/16#issuecomment-250809077, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKYesO4-lxNBwd-Jwbwps7ppcxrxLPfks5qvUv8gaJpZM4KDcad .