search

GRABOSM / Grab-Data

Grab Project Page
23 stars 5 forks source link

Reviewing and mapping POIs in Vietnam #117

Open GRABOSM opened 2 years ago

GRABOSM commented 2 years ago

Objective: Our Vietnam local teams have surveyed and are adding/reviewing the existing POIs in the some of the region of Vietnam.

Nha_Trang_skyline

By kenner116 - https://www.flickr.com/photos/kenner116/5860365204/, CC BY 2.0, https://commons.wikimedia.org/w/index.php?curid=20341965

Regions we are reviewing/mapping: Vietnam cities

Workflow: These are collected using the survey, a small team will be adding them on OSM.

Validation: We'll be following the validation guidelines mentioned in our wiki: https://wiki.openstreetmap.org/wiki/Grab#Quality_Process

Changeset Comment: Adding POIs: https://github.com/GRABOSM/Grab-Data/issues/117

Source: MAXAR -- we would refer to others if need be.

Filter: None

Plugins: None

Edge cases: None at the moment, we'll post it as a subsequent comment if need be.

Team involved:

Do reach out to us if you have any questions or suggestions on the same. Happy Mapping!

cc: @jinalfoflia

1ec5 commented 2 years ago

When renaming each VinMart+ location to WinMart+, the Grab team inadvertently tagged it as not:wikidata:brand=Q60245505, probably to silence a warning that wanted to rename it back to VinMart+. This is a bug that will be fixed by osmlab/name-suggestion-index#6821. Incidentally, I created a separate Wikidata item for WinMart+, so each location should now be tagged wikidata:brand=Q113236478.

Khi đổi tên các cửa hàng VinMart+ thành WinMart+, nhóm Grab tình cờ đặt thẻ not:wikidata:brand=Q60245505, chắc để khắc phục các cảnh báo gợi ý đổi tên lại thành VinMart+. Đây là lỗi phần mềm sẽ được sửa trong osmlab/name-suggestion-index#6821. Đồng thời, tôi đã tạo ra một khoản mục Wikidata mới cho WinMart+, nên mọi cửa hàng nên có thẻ wikidata:brand=Q113236478.

mapdevsaikat commented 2 years ago

Hello Minh Nguyễn, thank you for this update on WinMart+ wikidata tag. We have created this challenge to fix the tag for WinMart+, our team will be working on it but you can join the efforts too :)

1ec5 commented 2 years ago

Thank you for creating the challenge. It looks like the “Upgrade the tags” validator warning doesn’t appear after all. For some reason, iD won’t suggest brand:wikidata=Q113236478 when not:brand:wikidata=Q60245505 is present. But if I remove not:brand:wikidata=Q60245505, then it does suggest brand:wikidata=Q113236478. As a workaround, can you rearrange the third and fourth steps in the task instructions?

Also, it’s a good practice to add something descriptive to the default changeset comment, not just a hashtag. How about “Sửa các thẻ nhãn hiệu WinMart+” (“Corrected WinMart+ brand tags”)? Thanks!

/cc @bhousel

mapdevsaikat commented 2 years ago

Thank for your suggestions, I've updated the task instruction and changed the default changeset comment. :)

1ec5 commented 2 years ago

Thanks, looks good!

(It turns out that your previous instructions were technically correct too. I just wasn’t seeing the validator warning initially because MapRoulette selects the node automatically before iD has a chance to load all the NSI data. It doesn’t revalidate the node until several seconds after NSI loads. Deleting not:brand:wikidata=Q60245505 forces it to revalidate, so rearranging the instructions, as you’ve done, will make the task more efficient.)