search

GRESB / api-docs

http://gresb.github.io/api-docs/
3 stars 0 forks source link

Move property type code to the annual data section in the data dictionary #58

Closed joeyhorst closed 4 years ago

joeyhorst commented 4 years ago

In the data dictionary property_type_code is part of the asset and not the annual data. This needs to be moved to the annual data fields as per the example shown below.

Data Dictionary: https://gresb.github.io/api-docs/#data-dictionary Example comes from: https://gresb.github.io/api-docs/#asset-data-get-entities-entity_id-assets

[
    {
        "gresb_asset_id": 442,
        "country": "NL",
        "state_province": "Noord-Holland",
        "city": "Amsterdam",
        "address": null,
        "lat": null,
        "lng": null,
        "construction_year": 2000,
        "partners_id": "GRB_OFF_357891Z",
        "certifications": [
          {
            "id": 5913,
            "certification_id": 901,
            "name": "Sunshine Energy A",
            "level": "Premium",
            "size": "415.7"          
          }
        ],
        "annual_data": [
          {
              "year": 2019,
              "asset_name": "GRESB HQ",
              "asset_size": 500,
              "property_type_code": "OCHI"    
          },
          {
              "year": 2018,
              "asset_name": "GRESB HQ",
              "asset_size": 450,
              "property_type_code": "OCHI"
          },
          {
              "year": 2017,
              "asset_name": "GRESB Headquarter",
              "asset_size": 425,
              "property_type_code": "OCHI"    
          }
        ],
        "created_at": "2018-01-15T11:07:13.436Z",
        "updated_at": "2020-01-24T12:05:11.456Z"
    }
]
joeyhorst commented 4 years ago

@emmastorm I also noticed that asset_name is also annual and optional_information doesn't exist in the API (or at least it did not in 2019).

It is slightly different than the asset spreadsheet where we pretend that they are portfolio_assets fields 😉

emmastorm commented 4 years ago

also fixed now

joeyhorst commented 4 years ago

@gresbtim or @teoulas could you publish the latest changes to master?