search

GREsau / okapi

OpenAPI (AKA Swagger) document generation for Rust projects
MIT License
578 stars 103 forks source link

Validation via rocket-validation implementation and example project added #143

Closed saeedtabrizi closed 3 months ago

saeedtabrizi commented 4 months ago

Hi rust lovers ,

Just I pushed an implementation for support rocket-validation in okapi project . This is related to issue #142 that I already posted in yesterday .

I have created an example project to show my implementation works like a BENZ .

You may need more info about rocket validation so please look at rocket-validation repo and docs .

If you find it useful so pray a SALAVAT.

ralpha commented 3 months ago

Hey, Thanks for creating this MR. But I think this crate is not the location this should be implemented. It would be best located in the rocket-validation crate. That is where the Validated<T> struct is created. https://github.com/somehowchris/rocket-validation/blob/504302de2cc0248c826b411beacbcfb5ebc69950/src/lib.rs#L99

This way it could be maintained by the creator of the crate and this package does not get tasked updating the version used these crates. Because this could result in version mismatch in the future and will give everyone even more problems.

Sorry for referring you to an other project for this MR. I know this is common problem in Rust at the moment. Had the same problem many times before with schemars crate https://github.com/GREsau/schemars/issues/158#issuecomment-1179539073