GREsau / okapi

OpenAPI (AKA Swagger) document generation for Rust projects
MIT License
606 stars 110 forks source link

Extern crate #53

Closed TotalKrill closed 3 years ago

ralpha commented 3 years ago

Was this a miss click? Are you using this project in your company because I see some changes around security too. If you explain we can maybe add some of these features in the main repo. But this PR includes to much other things.

Also maybe usefull to know. You don't have to publish to crates.io in order to use your custom create in your project. You can also link strait to the git repo. This might be more useful if you want to do rapid changes. https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories

TotalKrill commented 3 years ago

This was a mis-click indeed. And yes, we are using this in our company to get swagger-uis for some APIs. We utilize JWT for security features and have implemented that as requests guards in rocket.

I have a pull-request for the majority of the changes in this repo, but looking at the frequency of reviews, the merge frequency and the response times of most of these issues, I found it better to fork and then hope that the projects can merge as soon as the original author finds time to maintain this. This is also why I found a solution that would enable users to very easily switch between the fork and this project, by only changing a tiny amount in their Cargo.toml

I am aware of that I can use git, but in my experience, its almost quicker to do a publish to crates, because it usually breaks less due to the versioning that crates.io has.