search

GRIDAPPSD / CIMHub

16 stars 10 forks source link

Use of ConnectivityNodeContainer as an EquipmentContainer is invalid #43

Closed AAndersn closed 4 months ago

AAndersn commented 11 months ago

CIMhub is using ConnectivityNodeContainer as master parent class and writing Equipment.EquipmentContainer attributes to this class.

https://github.com/GRIDAPPSD/CIMHub/blob/feature/SETO/BES/IEEE118_CIM.xml#L7

This is invalid and violates the CIM UML. ConnectivityNodeContainer is the parent class of EquipmentContainer and does not inherit the child relationship of EquipmentContainer.Equipments.

ConnectivityNodeContainer needs to be replaced with EquipmentContainer in all BES code.

...

image

temcdrm commented 10 months ago

https://github.com/Dewei-Wang-xx could handle this, starting at https://github.com/GRIDAPPSD/CIMHub/blob/feature/SETO/BES/raw/XMLtoCIM.py#L68 and https://github.com/GRIDAPPSD/CIMHub/blob/feature/SETO/BES/raw/XMLtoCIM.py#L772

temcdrm commented 4 months ago

Fixed here https://github.com/GRIDAPPSD/CIMHub/commit/68d2c388640e016a25e6aff54e7cce792f2aedc3