GRIFFIN Preprocessor

[bkatiemills]

Hi @pcbend @damiller @carlu @AdamGarnsworthy,

Just a heads up that I have decided that I will take a stab at writing the GRIFFIN preprocessor in TParser myself, once @r3dunlop produces some dummy GRIFFIN data for me to test it on (so don't sink your own time into it). I plan to do this by slavishly copying the TIGRESS example, and modifying it just enough to make it work for GRIFFIN - exactly how some thrid party trying to use the code would do. The point of this exercise is to see how hard a task this is for someone who didn't build the whole codebase, the hope being that the answer is 'pretty easy' - if I can do it, I think that's a reasonable if anecdotal test that we got the usability we wanted out of the preprocessor factorization.

[pcbend]

Before we do this we need to create a TGrifFragment which inherits from TFragment that adds the useful bits of things that are only griffin related. My guess is while doing this, we'll find things are either missing or need to be moved out of TFragment. This really needs to be done carefully before we spend much time on a parser.

Since this is the 'first' time this is being done in the production code, the task is not quite as easy as just getting the function right.

On Mon, Jan 27, 2014 at 12:30 PM, Bill Mills notifications@github.comwrote:

Hi @pcbend https://github.com/pcbend @damillerhttps://github.com/damiller @carlu https://github.com/carlu @AdamGarnsworthyhttps://github.com/AdamGarnsworthy ,

Just a heads up that I have decided that I will take a stab at writing the GRIFFIN preprocessor in TParser myself, once @r3dunlophttps://github.com/r3dunlopproduces some dummy GRIFFIN data for me to test it on (so don't sink your own time into it). I plan to do this by slavishly copying the TIGRESS example, and modifying it just enough to make it work for GRIFFIN - exactly how some thrid party trying to use the code would do. The point of this exercise is to see how hard a task this is for someone who didn't build the whole codebase, the hope being that the answer is 'pretty easy' - if I can do it, I think that's a reasonable if anecdotal test that we got the usability we wanted out of the preprocessor factorization.

— Reply to this email directly or view it on GitHubhttps://github.com/GRIFFINCollaboration/GRSISpoon/issues/35 .

[bkatiemills]

Aha! So there are some experiment-specific bits besides just the functions in TParser. That's fine - as long as TIGRESS fragments and GRIFFIN fragments are as well factorized and well labeled as the TParser functions. Don't misunderstand, I wasn't going to start this now - I was just mentioning it now so no one sunk a lot of time into it, not realizing I was going to do it. I'll be waiting at least until Ryan produces that test data before I even start, and it looks like TFragment needs to be finalized too - all in good time.

[pcbend]

OK, And yes the TFragment needs to be finalized. I don't know how to do this properly with out griffin data. I have taken a stab at it, but it may or may not be right depending on how the data stream is actually implemented.

On Mon, Jan 27, 2014 at 12:46 PM, Bill Mills notifications@github.comwrote:

Aha! So there are some experiment-specific bits besides just the functions in TParser. That's fine - as long as TIGRESS fragments and GRIFFIN fragments are as well factorized and well labeled as the TParser functions. Don't misunderstand, I wasn't going to start this now - I was just mentioning it now so no one sunk a lot of time into it, not realizing I was going to do it. I'll be waiting at least until Ryan produces that test data before I even start, and it looks like TFragment needs to be finalized too

• all in good time.

— Reply to this email directly or view it on GitHubhttps://github.com/GRIFFINCollaboration/GRSISpoon/issues/35#issuecomment-33420715 .

[bkatiemills]

Sounds good to me - Ryan is working on this presently, so we'll all have what we need soon enough.