search

GRIFFINCollaboration / Geant4GammaGammaAngularCorrelations10.01.p01

The gamma-gamma angular correlations code was written as an extension to the existing radioactive decay module in Geant4.10.01.
MIT License
2 stars 6 forks source link

Nonsensical mixing ratios #2

Closed SmithJK closed 8 years ago

SmithJK commented 8 years ago

If the multipole data file lists the same multipolarity twice, any mixing ratio besides 0 will give incorrect a2 and a4 values rather than flagging the input as nonsensical and correcting it.

Example UserMultipoleData_z28.a60:

1.3325180000e+03 1.332501e+03 2 2 0.5
2.5057660000e+03 1.173237e+03 2 0 0

This produces a2 and a4 values of 0.183673 and 0.0163265, respectively. Changing the mixing ratio to 0 gives the appropriate values of 0.102041 and 0.00907029. Is there a good function to include a check in?

evan012345 commented 8 years ago

Hey Jenna, You're right, those a2's and a4's are nonsensical, but to be fair, so is the input. But if you want to include a check, that doesn't hurt. We could add a check in one of two places, the ReadDataLineMultipole function in the G4NuclearLevelManager.cc, or the GenerateWThetaParameters function in G4NuclearLevel.cc. The former is where the multipole file is read in, and the latter is where the W(theta) function is calculated. I would say it probably makes the most sense to include a check in the GenerateWThetaParameters function in G4NuclearLevel.cc.

Did you want to include the check? Or I can, if you like.

SmithJK commented 8 years ago

I can include it.

Jenna On Nov 16, 2015 10:05 AM, "Evan Rand" notifications@github.com wrote:

Hey Jenna, You're right, those a2's and a4's are nonsensical, but to be fair, so is the input. But if you want to include a check, that doesn't hurt. We could add a check in one of two places, the ReadDataLineMultipole function in the G4NuclearLevelManager.cc, or the GenerateWThetaParameters function in G4NuclearLevel.cc. The former is where the multipole file is read in, and the latter is where the W(theta) function is calculated. I would say it probably makes the most sense to include a check in the GenerateWThetaParameters function in G4NuclearLevel.cc.

Did you want to include the check? Or I can, if you like.

— Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/Geant4GammaGammaAngularCorrelations10.01.p01/issues/2#issuecomment-157121500 .

SmithJK commented 8 years ago

Turns out I haven't forked this yet, only cloned it. I suggest then, that you include the check. Though, since I wrote the check before I realized this...

  // a check for non-sensical spin/mixing ratio combinations
  if (L1==L1p) delta1 = 0;
  if (L2==L2p) delta2 = 0;
evan012345 commented 8 years ago

Done. Thanks Jenna.