GRIFFINCollaboration / griffin-dashboard

MIT License
3 stars 3 forks source link

overlapping PPG patterns #87

Open bkatiemills opened 8 years ago

bkatiemills commented 8 years ago

I noticed while working on #86 that the codes in the PPG pattern table for the unassigned outputs are subsets of other patterns - like for example, 'unassigned output 3' (0x00040004) is a subset of 'collect data with beam off' (0xC004C004), so it's impossible to tell if those two have been or'ed together or not. Maybe not fatal given that they're just unassigned outputs at the moment - but could get worse if we ever decide to use those for something.

AdamGarnsworthy commented 8 years ago

You are correct.