search

GRTLCollaboration / GRChombo

An AMR based open-source code for numerical relativity simulations.
BSD 3-Clause "New" or "Revised" License
82 stars 53 forks source link

Update nancheck to ensure exit using openmp #239

Open KAClough opened 1 year ago

KAClough commented 1 year ago

Fixes #238.

Also (just because I had this in my code already) implements the output of physical coordinates instead of integer ones if m_dx is passed by the user.

@mirenradia would you support moving the NanCheck to specificPostTimestep() instead of specifiAdvance()? I think this is a historic thing - I don't see that you gain much by exiting during a RK4 substep rather than at the end, and it means it runs a load more times. If so I would updated this in the Examples here.

mirenradia commented 1 year ago

Since this conflicts with changes in #236, let's wait until that is merged before rebasing the changes here onto that.