search

GRTLCollaboration / GRTeclyn

Port of GRChombo to AMReX - under development!
BSD 3-Clause "New" or "Revised" License
4 stars 2 forks source link

Performance degradation on GPU runs due to clang-tidy fixes #22

Closed draenog closed 1 year ago

draenog commented 1 year ago

Commit f668054bac351517d29c7295675f4b24b6ce42b0 causes performance degradation on GPUs. On my test run on A100 time spent in BinaryBHLevel::specificEvalRHS increased from 4.683s to 6.612s. In particular the culprit is change https://github.com/GRChombo/GRAMReX/commit/f668054bac351517d29c7295675f4b24b6ce42b0#r108295816.

The next step would be to test if the change affect the final results.

mirenradia commented 1 year ago

That's a pretty big performance hit for just default-initializing some values. I will revert it any case and disable linting for the relevant line.

The change didn't seem to affect the results of the regression test but of course this is just on plain old CPUs.

mirenradia commented 1 year ago

Thanks for spotting this, @draenog!