Open mirenradia opened 1 month ago
@julianakwan, would you be able to check this resolves the CI issues you were finding on your matter/scalar field branches?
@julianakwan, would you be able to check this resolves the CI issues you were finding on your matter/scalar field branches?
Yeah, I'll test it out as a part of my usual suite of checks for PRs :)
I merged the bugfix/68
branch into the enhancement/scalar_fields
branch to test if the new Makefile would fix the race condition in the Example builds but unfortunately it did not - see failed GPU workflow here.
@mirenradia suggested separating out each example in the Examples
directory and building them individually as a possible workaround.
This adds a base Makefile that should be common to GRTeclyn examples (once there is more than one) and eventually the tests too.
There is also a new
amrex-objects
target in the root makefile which should fix #68 as it is a dependency of the examples targets although this does rely on the examples keeping the same default configuration (i.e.USE_MPI = TRUE
,COMP = gnu
).I have added a base name to the BinaryBH example.