GRVYDEV / Lightspeed-webrtc

A RTP -> WebRTC broadcast server for Project Lightspeed.
MIT License
75 stars 31 forks source link

Allow passing port range and IP address for ICE connections #16

Closed k3d3 closed 3 years ago

k3d3 commented 3 years ago

At the moment, if you run lightspeed-webrtc within a docker container, it will try to announce a candidate of a completely random port, and a local 172.x.x.x IP address (basically, the IP within the container). This causes the stream to never reach the browser.

As for the port ranges, Pion appears to pick any port randomly. By passing a port range, we can also pass the same (restricted) port range to Docker or docker-compose and successfully pass the ICE connections through.

In the same way that the websocket addr can be given via --addr, a public-facing IP address and a set of ports should be set through something like --ip and --ports.

GRVYDEV commented 3 years ago

This is a great idea! I would love to see this implemented