search

GRVYDEV / Lightspeed-webrtc

A RTP -> WebRTC broadcast server for Project Lightspeed.
MIT License
75 stars 31 forks source link

Statically link binary and remove dependency on debian:buster-slim #26

Closed geneccx closed 3 years ago

geneccx commented 3 years ago

Corresponding to https://github.com/GRVYDEV/Lightspeed-ingest/pull/35 statically linking the binary and removing the dependency on buster-slim makes the image smaller.

geneccx commented 3 years ago

What's needed to get this (and https://github.com/GRVYDEV/Lightspeed-ingest/pull/35) moving along?

GRVYDEV commented 3 years ago

What's needed to get this (and GRVYDEV/Lightspeed-ingest#35) moving along?

Afaik statically linking Go Binaries with the net package is a no-no meaning this could break on some operating systems

geneccx commented 3 years ago

The only mention I can find of this seems to be an issue from 2011 where sometimes including the net module causes the binary to still have dynamic links. Is this what you're referencing? If so I don't think it's an issue anymore, I have verified that it works with just the binary itself, and has been stable. Any other concerns I'm missing and could dig into?