GRVYDEV / Project-Lightspeed

A self contained OBS -> FTL -> WebRTC live streaming server. Comprised of 3 parts once configured anyone can achieve sub-second OBS to the browser livestreaming
MIT License
3.63k stars 137 forks source link

Ubuntu installer script assumes some components are not already installed #62

Open Huskion opened 2 years ago

Huskion commented 2 years ago

The Ubuntu installer script does not just install project lightspeed, it also installs the package manager version of nginx (and certbot if TLS option is chosen) and overwrites any existing setup/configuration on the system that someone might have.

Lost my whole nginx configuration because there was no warning, it just went and overwrote it, I thought I was installing lightspeed :)

Please make this optional so that if anyone attempts this script on not a fresh system, their existing configs don't get silently obliterated

Also, when certbot realized my domain was already set up, it hit a snag and the installation script didn't complete.

SpoopyTim commented 2 years ago

As of right now Lightspeed is being designed to be used with docker. We are currently in the transitioning period so it may not be obvious from the README.

Please make this optional so that if anyone attempts this script on not a fresh system, their existing configs don't get silently obliterated

The ubuntu installer that you were using was created by a user as a contribution to work as an aid for the old system and as of such isn't a priority. Anyone is free to submit a PR to address this.

I have submitted a PR to address the issue with there being no warning in the documentation for the script to hopefully avoid people encountering the same issue in the future.