GSA-TTS / 10x-website

[LIVE] 10x 11ty site
https://10x.gsa.gov
3 stars 0 forks source link

Updated homepage and added the project status link #213

Closed natashapl closed 2 months ago

natashapl commented 2 months ago

This pull request includes the following update:

PR Preview

natashapl commented 2 months ago

Hi @iamjolly . Hope all is well. In this task, we've updated the main top navigation of the 10x website and added a "Project Status" link. When you have a moment, could you please perform some additional accessibility testing and let us know if we overlooked anything? Thanks so much!

Click here to access the branch.

iamjolly commented 2 months ago

@natashapl - Things check out fine in general on the new link, with a couple of minor comments/suggestions:

  1. The Github icon is cool, but the accessible name for the link is simply "Project Status". I think as-is, it is OK, but would be even better to be "Project Status on Github" as the accessible name for the link. For this, you may want to use visually-hidden text in a span within the a to add to the link text. It's optional, but seems like it could be a nice touch.
  2. Focus outline is great for this link and is fine as-is. I really like the :hover color change from white to light blue and would recommend that also be applied to the :focus in the CSS, along with the focus outline. Again, not a big deal if it's not implemented, just a nice touch visually.
natashapl commented 2 months ago

Hi @iamjolly . Thanks for you suggestions. They've both been implemented. Please review when you get a chance. By the way, I added you as a reviewer. Thanks.

jonadecker commented 2 months ago

This looks really good @natashapl! Thanks for your help on this @iamjolly