search

GSA-TTS / FAC

GSA's Federal Audit Clearinghouse
Other
19 stars 5 forks source link

Upload Page Timeout #1050

Closed jperson1 closed 1 year ago

jperson1 commented 1 year ago

Related to https://github.com/GSA-TTS/FAC/issues/928

At a glance

The user is notified if their file upload was unsuccessful due to a timeout.

Acceptance Criteria

In the event of a server timeout for whatever reason (long processing time, crash, etc.), the frontend should timeout the response and let the user know.

Background

The relevant HTTP request is made in /backend/static/js/upload-page.js. Some sort of timeout function should be written that aborts this request and updates the info_box on the frontend.

jadudm commented 1 year ago

This was previously implemented, then commented out. We need, as a team, to decide what the timeout should be, and why. Then, we'll bring it back.

jadudm commented 1 year ago

Lets choose 30 seconds. :gavel: Arbitrary. To be revisited based on testing.

mogul commented 1 year ago

Note the lack of a timeout limit came up explicitly in our assessment. I'm leaving this a SHOULD (and on the board) for now, but it may need to move up to a MUST if it's determined to be a big risk blocking our ATO (seems doubtful, but...).