Add character limits to fields

LeoFotovich commented 10 months ago

Background

We should have limits on our intake fields. This means both the spreadsheets and the webforms.

### Tasks
- [x] Use API and historic data to get min, max, median lengths for every field
- [ ] Discuss how to do this for the web forms and spreadsheets
- [ ] Document decision
- [ ] Design consistent (table-driven, so to speak) approach for all inputs.
- [ ] ...
- [ ] Document limits for users in submission guide/howto.

We now have historic data; we can do some quick API work to evaluate various fields, and set sensible limits across the board. We might end up with four size buckets.

Once we know what we're facing, and have an idea how to do the implementation, we can revise this ticket to better support/track the implementation work.

Describe the bug

There is no current character limit on "Auditee Name" under General Info. This does not cause a crash, however, creates some pretty funny results when going back to the landing page and the "in progress" audits page.

Steps to reproduce the bug

Go to "Auditee Name" under General info and input a bunch of characters

Expected Behavior

For there to be some limit on characters, or for the inputted name to not show up on other parts of the website

Screenshots

System setup

No response

Additional context

No response

Code of Conduct

[X] I agree to abide by the Digital.gov Community Guidelines and the TTS Code of Conduct. Respect your peers, use plain language, and be patient.
[X] I checked the current issues for duplicate bug reports.

danswick commented 7 months ago

Most form fields should have a character limit and those limits should be based on real data. These should be done as a single project rather than field-by-field.

danswick commented 2 months ago

This looks pretty stale, so I'm moving it back to "backlog." If you're working on it right now, could you link to a PR or branch, @phildominguez-gsa?

GSA-TTS / FAC