Closed austinhernandez closed 2 years ago
Let's not mess with the nav right now.
The scope of this is really just adding some copy to let folks know about the auditee address field.
Auditee address should be auto-populated from SAM.gov. This field should not be editable here. If people don’t have a valid UEI, these fields will be uneditable and blank. We’ll want to include some copy that tells them these fields will be populated by sam.gov when they add a UEI.
With this narrowed scope, I think we might actually be able to punt on this refinement until later on down the road. cc @petermarks-gsa
To clarify...
Is this correct? Is there any other information that gets pre-populated?
I cant think of anything else, a Report ID # gets generated regardless, but not pre-populated, you have to manually enter the entity type...
@tadhg-ohiggins In case there's any other SAM.gov auto-populated content we missed ^
As far as I know, we get UEI, auditee name, and auditee mailing address. (If we get anything; there may be cases where we get no results, and there may be cases where we get UEI and zero, one, or two of the other fields.)
Awesome, thanks for confirming!
I didnt work on this section, so I am less familiar with it than the other pages, but this seems right
Is this the only place you can update to a valid UEI?
This is the second opportunity auditor/ees have to fill out UEI, the first of which being in the "Create Audit" flow:
https://www.figma.com/file/1bNncVt1TcFFDhQslqFC2o/FAC-Playground?node-id=2552%3A11276
If they confirmed their UEI in that flow, then when they get to this screen, we've already pre-populated their information. We don't want their information to get out of sync with what's coming from SAM.gov, so they can't change any pre-populated information (without changing the UEI).
If they haven't confirmed their UEI, this is their second chance to correct that.
Is this the only place you can update to a valid UEI?
We currently have an "edit" link next to the UEI in the header of each of these pages:
Which then opens up this modal, which I've based this page's flow on:
https://www.figma.com/file/1bNncVt1TcFFDhQslqFC2o/FAC-Playground?node-id=3136%3A18722
Q: With an invalid UEI, they can enter in all this information. Does it just gets overwritten when the correct info is put in? Does that need some kind of notification?
Yeah you know what that's a great point, I should just remove those fields if you have't confirmed your UEI, since they would get overwritten once you enter a valid number.
I just wanted to note about disabled and read-only form fields for screen readers as it has been confusing for me in the past: https://tink.uk/screen-reader-support-for-disabled-read-only-form-fields/
Thank you!! I'll review this.
I'm wondering if it makes sense to have the edit UEI
link go to the "SF-SAC: General Info" page since more than just the UEI is updating and it will remove the information that was added before.
Also, will the UEI be editable always or only in the case of an invalid UEI?
Here are my thoughts on editing UEI and its related fields:
UEI and auditee name (and likely auditee address, in future) will be populated and non-editable. To change the UEI, the user will have to go through a flow that should basically replicate the flow of their initially entering it. This includes the path for an unsuccessful UEI lookup.
The user has to enter auditee name (and likely address, in future). These (including UEI) will be shown as non-editable in the general view, just as with the successful UEI flow. To change them, the user will have to go through a flow that should basically replicate the flow of their initially trying to enter UEI.
In the short term, however, this special flow for editing later doesn't exist, so whatever happens first time through is going to stay that way until the edit flow is implemented.
Those thoughts are based on the technical constraints around the fact that these fields are special, in they they're not supposed to be user-editable but we're supporting some cases where they are because we can't fully rely on UEI.
Thanks @tadhg-ohiggins!
Based on this feedback and a conversation with @austinhernandez, I've explored what it could look like if you confirmed your UEI during the Audit Start section:
If previously confirmed, the UEI is no longer editable. (Austin and I agreed that once you confirm your UEI, it shouldn't be editable anywhere. Please let us know if this should not be the case!)
I've grouped the UEI, along with any information populated by SAM.gov, into the same section as informational text. I opted to not use readonly
text fields due to the accessibility concerns in the article Austin linked above.
If this seems like the right track, I'll work on updating the flow for if you have not previously confirmed your UEI.
I also added a little more information to the "more numbers to add" questions to make it more clear that if you do have more numbers to add, you'll be able to do so later in the field.
For the future, it might also be worth looking at merging the "add multiple EINs/UEIs" pages into this one, depending on if:
@melchoyce From my perspective, implementation for this will be covered in https://github.com/GSA-TTS/FAC/issues/402. We can discuss specifics at backlog refinement tomorrow. Proposing we close this for now. cc @tadhg-ohiggins
One last update — cleaned up the page and designed how to access the UEI search modal when your UEI isn't confirmed: https://www.figma.com/file/1bNncVt1TcFFDhQslqFC2o/FAC-Playground?node-id=4398%3A21480
We decided that the field for Auditee email should be a text field, not a dropdown.
Breakout issue of #274
Background Sprint 6 research - observations/refinements by page
Observation(s)
MVP recommendation(s)
Tasks
Definition of done Acceptance Criteria (We'll know we're done when...)