GSA-TTS / FAC

GSA's Federal Audit Clearinghouse
Other
18 stars 5 forks source link

Enable removal of editors, certifiers from SF-SAC records #3409

Open jadudm opened 4 months ago

jadudm commented 4 months ago

What problems are we trying to solve?

Currently, it is possible to:

  1. Add editors to an audit submission.
  2. Change certifying officials.
  3. Change editors.

It is not possible to remove editors. This is a problem.

What can we do today?

Context and further reading

We have discussed via the ADR process.

Link to ADR when it is complete.

### Requirements
- [ ] Add a Remove link to the current access management table
- [ ] Add a Remove page for deleting an Auditor Access role
- [ ] Create a method for audit.views.manage_submission_access.ChangeOrAddRoleView to support deletion
- [ ] Ensure that the new method does not allow deletion when the email in the Access object being deleted matches the email of the current user
- [ ] Add documentation for this feature
- [ ] Track how many requests we get for removing Certifying Official roles without supplying a replacement
- [ ] Potentially add documentation suggesting that larger organizations always add at least two of their staff in the Audit Editor role, to ensure that they do not get stuck without access to an audit if one of their staff members leaves
jadudm commented 4 months ago

The "verify completed audits" story is supported in part by tickets like this:

https://fac-gov.zendesk.com/agent/tickets/2356