github-actions[bot]
commented
1 month ago Terraform plan for meta
No changes. Your infrastructure matches the configuration.
``` No changes. Your infrastructure matches the configuration. Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed. Warning: Argument is deprecated with module.s3-backups.cloudfoundry_service_instance.bucket, on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket": 14: recursive_delete = var.recursive_delete Since CF API v3, recursive delete is always done on the cloudcontroller side. This will be removed in future releases ```:white_check_mark: Plan applied in Deploy to Development and Management Environment #692
This PR is linked to:
3485
This PR will close:
3574
In this PR:
gen-info,initialize-audit, &check-accessfrompage_objects.testValidGeneralInfoin../support/general-info.js.elementsobject rather than keeping multiple element identifiers as strings.downloadFilefor cypress and added it as a task incypress.config.js.commands.jsfile the linerequire(cypress-downloadfile)was added.Cypress-downloadfilewas added topackage-lock.json&package.json.search-tests.cy.jsto e2e, which has four tests 1) basic search test, 2) advance search test, 3) basic search test that return results and downloads summary report, & 4) test reset button and assert fields are empty.How to test:
Pull this branch, now since we're using a plugin for cypress, we need to make sure to download it locally on our machine or the tests won't work for search. Make sure you're on the backend directory of the project and run
npm i --save-dev cypress-downloadfile. Once installed, you should see in your IDE a new folder titled downloads appear in the cypress directory, it should appear just under cypress but before e2e.Run docker as you normally would and once docker is running on another tab run this command
docker compose exec web /bin/bashthis will get you into docker shell. After that, run this commandpython manage.py materialized_views --create. (I had to do this since I didn't have materialized view and my search tests would fail but after running command they passed)Now in your terminal, enter your cypress env variables and run npx cypress open
Once cypress is open, run the
full-submission.cy.jstests should pass may take one or two tries for them but once they are completed run the commandpython manage.py materialized_views --refreshand now runsearch-tests.cy.jsNote: BEFORE running search tests, you'll notice that in your cypress downloads folder you won't have anything in there but AFTER running search tests, a sf-sac-summary-report.xlsx and/or a single-audit-report.pdf will show up, indicating that the download did work.
PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.