search

GSA-TTS / FAC

GSA's Federal Audit Clearinghouse
Other
19 stars 5 forks source link

Add access deletion ADR #3897

Closed tadhg-ohiggins closed 4 months ago

tadhg-ohiggins commented 4 months ago

Sometimes people leave
Sometimes people get kicked out
Either way: bye-bye.

Add Architecture Decision Record for adding ability to remove Audit Editor roles from submissions.

See https://github.com/GSA-TTS/FAC/issues/3881 for earlier discussion.

jadudm commented 4 months ago

Only one comment:

It looks like there are two "Story 2" entries? (I'm reading the merge, so perhaps I'm confusing myself.)

I would suggest removing story 3. It speaks to what we won't do, suggesting features we don't have and aren't discussing (adding users out-of-band). I think it can safely be removed, because the list of features we aren't discussing in this ADR is infinite. Story 1 and Story 2 capture what we're doing: providing the ability for people to remove Editors, and they can't remove themselves.

Unless I'm still missing why that story is critical for scoping the feature/decision.

tadhg-ohiggins commented 4 months ago

@jadudm agreed, that was more of an exploratory segment and doesn't need to be in the ADR; removed.