github-actions[bot]
commented
2 weeks ago Terraform plan for dev
Plan: 4 to add, 2 to change, 2 to destroy.
```diff Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: + create !~ update in-place -/+ destroy and then create replacement <= read (data resources) Terraform will perform the following actions: # module.dev.cloudfoundry_network_policy.logshipper-network-policy will be updated in-place !~ resource "cloudfoundry_network_policy" "logshipper-network-policy" { id = "f188b467-82e6-e5d6-bae1-138086a288c5" + policy { + destination_app = "a6eb3870-2769-4aa9-a8f2-f1a31939f563" + port = "61443" + protocol = "tcp" + source_app = (known after apply) } } # module.dev.module.cg-logshipper.cloudfoundry_app.cg_logshipper_app will be created + resource "cloudfoundry_app" "cg_logshipper_app" { + buildpack = (known after apply) + buildpacks = [ + "https://github.com/cloudfoundry/apt-buildpack", + "nginx_buildpack", ] + disk_quota = 256 + enable_ssh = (known after apply) + environment = (sensitive value) + health_check_http_endpoint = (known after apply) + health_check_invocation_timeout = (known after apply) + health_check_timeout = (known after apply) + health_check_type = "process" + id = (known after apply) + id_bg = (known after apply) + instances = 1 + memory = 256 + name = "logshipper" + path = "../shared/modules/cg-logshipper/logshipper.zip" + ports = (known after apply) + space = "06525ba3-19c2-451b-96e9-ea4a9134e8b9" + stack = (known after apply) + stopped = false + strategy = "rolling" + timeout = 180 + routes { + port = (known after apply) + route = (known after apply) } + service_binding { + service_instance = "03df74b7-065a-46df-9a85-0bac201bf36c" } + service_binding { + service_instance = "29c42cfd-0722-4152-858e-d16521f1a694" } + service_binding { + service_instance = "d79b8e4c-c1f5-4711-8172-5da3f9298cc4" } } # module.dev.module.cg-logshipper.cloudfoundry_route.logshipper will be created + resource "cloudfoundry_route" "logshipper" { + domain = "50ba3f69-cd54-4963-9172-14f3334b479e" + endpoint = (known after apply) + hostname = "fac-dev-logshipper" + id = (known after apply) + port = (known after apply) + space = "06525ba3-19c2-451b-96e9-ea4a9134e8b9" } # module.dev.module.file_scanner_clamav.data.cloudfoundry_app.app will be read during apply # (config refers to values not yet known) <= data "cloudfoundry_app" "app" { + buildpack = (known after apply) + command = (known after apply) + disk_quota = (known after apply) + enable_ssh = (known after apply) + environment = (sensitive value) + health_check_http_endpoint = (known after apply) + health_check_timeout = (known after apply) + health_check_type = (known after apply) + id = (known after apply) + instances = (known after apply) + memory = (known after apply) + name = (known after apply) + name_or_id = "****************" + space = (known after apply) + stack = (known after apply) + state = (known after apply) } # module.dev.module.file_scanner_clamav.data.cloudfoundry_domain.internal will be read during apply # (depends on a resource or a module with changes pending) <= data "cloudfoundry_domain" "internal" { + domain = (known after apply) + id = (known after apply) + internal = (known after apply) + name = "apps.internal" + org = (known after apply) } # module.dev.module.file_scanner_clamav.data.cloudfoundry_space.space will be read during apply # (depends on a resource or a module with changes pending) <= data "cloudfoundry_space" "space" { + id = (known after apply) + name = "dev" + org = (known after apply) + org_name = "gsa-tts-oros-fac" + quota = (known after apply) } # module.dev.module.file_scanner_clamav.cloudfoundry_app.clamav_api must be replaced -/+ resource "cloudfoundry_app" "clamav_api" { + buildpack = (known after apply) !~ enable_ssh = true -> (known after apply) + health_check_http_endpoint = (known after apply) !~ health_check_invocation_timeout = 0 -> (known after apply) !~ health_check_timeout = 0 -> (known after apply) !~ id = "************************************" -> (known after apply) !~ id_bg = "************************************" -> (known after apply) - labels = {} -> null name = "fac-av-dev-fs" !~ ports = [] -> (known after apply) !~ space = "06525ba3-19c2-451b-96e9-ea4a9134e8b9" # forces replacement -> (known after apply) # forces replacement + stack = (known after apply) # (9 unchanged attributes hidden) - routes { - port = 0 -> null - route = "d471b94d-6031-4589-85f7-64a50f3f9dd2" -> null } + routes { + port = (known after apply) + route = (known after apply) } } # module.dev.module.file_scanner_clamav.cloudfoundry_network_policy.clamav_routing will be updated in-place !~ resource "cloudfoundry_network_policy" "clamav_routing" { id = "a12e15b9-a189-47d2-cd69-95a38056d3b5" - policy { - destination_app = "2a10693f-1166-465a-93c9-8291585eeac5" -> null - port = "61443" -> null - protocol = "tcp" -> null - source_app = "bfcc67a1-8ace-45fe-b472-0594da8ab39b" -> null } + policy { + destination_app = (known after apply) + port = "61443" + protocol = "tcp" + source_app = (known after apply) } } # module.dev.module.file_scanner_clamav.cloudfoundry_route.clamav_route must be replaced -/+ resource "cloudfoundry_route" "clamav_route" { !~ domain = "26df58ef-0c0d-4997-b68b-8defb7b3998b" # forces replacement -> (known after apply) # forces replacement !~ endpoint = "fac-av-dev-fs.apps.internal" -> (known after apply) !~ id = "************************************" -> (known after apply) + port = (known after apply) !~ space = "06525ba3-19c2-451b-96e9-ea4a9134e8b9" # forces replacement -> (known after apply) # forces replacement # (2 unchanged attributes hidden) } Plan: 4 to add, 2 to change, 2 to destroy. Warning: Argument is deprecated with module.dev.module.cg-logshipper.module.s3-logshipper-storage.cloudfoundry_service_instance.bucket, on /tmp/terraform-data-dir/modules/dev.cg-logshipper.s3-logshipper-storage/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket": 14: recursive_delete = var.recursive_delete Since CF API v3, recursive delete is always done on the cloudcontroller side. This will be removed in future releases (and 4 more similar warnings elsewhere) ```:white_check_mark: Plan applied in Deploy to Development and Management Environment #719
Description
The FAC app currently lacks the logic to handle ACE audit reports, making it infeasible to migrate historical ACE reports using the same algorithm as for other reports. Consequently, the team has decided to make ACE reports available for download in CSV format. Additionally, users will have the ability to download PDF reports. However, these reports are stored on an S3 bucket and require a temporary token for access, which is currently only obtainable through the FAC app. To address this, users will need to interact with the FAC app to obtain the appropriate links to download the PDF reports. To facilitate access, we will create a generic SAC object for each ACE report with basic information on the report. When users attempt to access ACE reports from the static web and wish to download a PDF, they will be directed to the corresponding disseminated SAC object, which will provide them with the correct download link. This PR involves updating the logic in census_historical_migration module to identify ACE reports and generate the required SAC objects, along with the dissemination processes needed to make these available to the public.
How to test
audit_year=2022 and dbkey=254036and notice how it fails due to "ACE report type"PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.