search

GSA-TTS / FAC

GSA's Federal Audit Clearinghouse
Other
18 stars 5 forks source link

Add option to only detected changed files #4052

Open asteel-gsa opened 5 days ago

asteel-gsa commented 5 days ago

Dan and I agree, the coverage report is good, but its bloated, hard to read, and often ignored.

Now the only coverage added to the PR is if the code is changed/added, and used with Django/Coverage. Should make things a lot easier to read.

github-actions[bot] commented 5 days ago

Terraform plan for meta

No changes. Your infrastructure matches the configuration. ``` No changes. Your infrastructure matches the configuration. Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed. Warning: Argument is deprecated with module.s3-backups.cloudfoundry_service_instance.bucket, on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket": 14: recursive_delete = var.recursive_delete Since CF API v3, recursive delete is always done on the cloudcontroller side. This will be removed in future releases ```

:memo: Plan generated in Pull Request Checks #3264

github-actions[bot] commented 5 days ago

Terraform plan for dev

Plan: 0 to add, 2 to change, 0 to destroy. ```diff Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: !~ update in-place Terraform will perform the following actions: # module.dev.module.clamav.cloudfoundry_app.clamav_api will be updated in-place !~ resource "cloudfoundry_app" "clamav_api" { !~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:4a1a6213c26ca83d2cc401b71d665fc7f3402df13c14c4d9b0d77b006a334497" -> "ghcr.io/gsa-tts/fac/clamav@sha256:0223624d99f6c90bd9f375bcca01ec00dc7d68eb9f075d602dd9e71cbb5224b9" id = "779bbc51-f78a-4186-90eb-5acb68d7d746" name = "fac-av-dev" # (17 unchanged attributes hidden) # (1 unchanged block hidden) } # module.dev.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place !~ resource "cloudfoundry_app" "clamav_api" { !~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:4a1a6213c26ca83d2cc401b71d665fc7f3402df13c14c4d9b0d77b006a334497" -> "ghcr.io/gsa-tts/fac/clamav@sha256:0223624d99f6c90bd9f375bcca01ec00dc7d68eb9f075d602dd9e71cbb5224b9" id = "65c83416-4126-4785-99c2-5e1adb810422" name = "fac-av-dev-fs" # (17 unchanged attributes hidden) # (1 unchanged block hidden) } Plan: 0 to add, 2 to change, 0 to destroy. Warning: Argument is deprecated with module.dev-backups-bucket.cloudfoundry_service_instance.bucket, on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket": 14: recursive_delete = var.recursive_delete Since CF API v3, recursive delete is always done on the cloudcontroller side. This will be removed in future releases (and 6 more similar warnings elsewhere) ```

:memo: Plan generated in Pull Request Checks #3264

github-actions[bot] commented 5 days ago

File Coverage Missing
All files 87% :white_check_mark:

Minimum allowed coverage is 85%

Generated by :monkey: cobertura-action against bb11bdd35ac51405910275d76700ad4efab303bc