FAC - Bug: POST /audit/auditee-certification-confirm creating 500 error with invalid date input

rnovak338 commented 3 months ago

Describe the bug

A 500 error response to the endpoint caught from the past week: POST /audit/auditee-certification-confirm/2022-06-GSAFAC-0000052214

NewRelic log can be found here.

When auditee-certification-date-signed in the payload of this request is provided an incorrect format (e.g. "204-08-12") the backend returns a 500 error response.

Steps to reproduce the bug

On the Auditor or Auditee certification steps when the signature must be filled out, you will be able to supply a date for your signature. By typing MM/DD/0204, this error will occur.

Note - Do not skip out on the leading zero (e.g. MM/DD/204) as the front-end input validation will trigger.

Expected Behavior

The user is likely expected to get a data-validation prompt when an invalid date is inputted rather than a 500 response.

Screenshots

System setup

No response

Additional context

No response

Code of Conduct

[X] I agree to abide by the Digital.gov Community Guidelines and the TTS Code of Conduct. Respect your peers, use plain language, and be patient.
[X] I checked the current issues for duplicate bug reports.

rnovak338 commented 3 months ago

@danswick not sure how to flesh out the "Steps to Reproduce" as these have been found through NewRelic. Please advise.

danswick commented 3 months ago

Oops, replied to the wrong one! I'm not sure how this is even possible. Are there any older logs with the same error?

rnovak338 commented 3 months ago

@danswick Strangely enough, this appears to be the first case this year from querying NewRelic for the error.

GSA-TTS / FAC