Scenario: The only way to submit this information is via XLSX upload.
Given that I cannot complete a form to submit this information
when submitting the secondary auditors
### then...
- [ ] the XLSX workbook is no longer a button/javascript action, but a link to a static file with properties set to force the browser to download
- [ ] copy is updated on the secondary auditors upload page to reflect that this is now a single-step process
- [ ] the Figma mocks are updated to reflect the new design
Scenario: An auditor/auditee uploads a XLSX document.
Given that the XLSX is correct
when they upload the file
...
### then...
- [ ] the JSON schema for the secondary auditors is authored/updated
- [ ] unit tests for secondary auditors JSON schema written
- [ ] the secondary auditors page is authored in the frontend
- [ ] the secondary auditors upload is connected to the backend for storage
- [ ] validations run on the secondary auditors frontend (filename, extensions, etc.)
- [ ] validations run on the secondary auditors backend (via JSON schema)
- [ ] errors found on the secondary auditors backend are reported to the user
- [ ] E2E passing tests exist for secondary auditors page
- [ ] E2E failing tests exist for secondary auditors page
Process checklist
# Sketch
[comment]: # "Notes or a checklist reflecting our understanding of the selected approach"
[The Figma mocks for the page](https://www.figma.com/file/1bNncVt1TcFFDhQslqFC2o/FAC-Playground?node-id=4954-23338&t=azeQNyHI1V1Ll58h-4).
- [ ] Design designs all the things
- [ ] Engineering engineers all the things
# Definition of Done
## Triage
### If not likely to be important in the next quarter...
- [ ] Archived from the board
### Otherwise...
- [ ] Has a clear story statement
- [ ] Design or Engineering accepts that it belongs in their respective backlog
## Design Backlog
- [ ] Has clearly stated/testable acceptance criteria
- [ ] Meets the design Definition of Ready [citation needed]
- [ ] A design shepherd has been identified
## Design In Progress
- [ ] Meets the design Definition of Done [citation needed]
## Design Review Needed
- [ ] Necessary outside review/sign-off was provided
## Design Done
- [ ] Presented in a sprint review
- [ ] Includes screenshots or references to artifacts
### If no engineering is necessary
- [ ] Tagged with the sprint where it was finished
- [ ] Archived
## Engineering Backlog
- [ ] Has clearly stated/testable acceptance criteria
- [ ] Has a sketch or list of tasks
- [ ] Can reasonably be done in a few days (otherwise, split this up!)
## Engineering Available
- [ ] There's capacity in the `In Progress` column
- [ ] An engineering shepherd has been identified
## Engineering In Progress
- [ ] Meets acceptance criteria
- [ ] Meets [QASP conditions](https://derisking-guide.18f.gov/qasp/)
### If there's UI...
- [ ] Screen reader - Listen to the experience with a screen reader extension, ensure the information presented in order
- [ ] Keyboard navigation - Run through acceptance criteria with keyboard tabs, ensure it works.
- [ ] Text scaling - Adjust viewport to 1280 pixels wide and zoom to 200%, ensure everything renders as expected. Document 400% zoom issues with USWDS if appropriate.
## Engineering Blocked
- [ ] Blocker removed/resolved
## Engineering Review Needed
- [ ] Outside review/sign-off was provided
## Engineering Done
- [ ] Presented in a sprint review
- [ ] Includes screenshots or references to artifacts
- [ ] Tagged with the sprint where it was finished
- [ ] Archived
jadudm
commented
1 year ago
At a glance
In order to upload my secondary auditors as a spreadsheet as an auditor/auditee I want things to just work, or clear notification if they don't.
See #462 for prior art.
Acceptance Criteria
We use DRY behavior-driven development wherever possible.
Scenario: The only way to submit this information is via XLSX upload.
Given that I cannot complete a form to submit this information when submitting the secondary auditors
Scenario: An auditor/auditee uploads a XLSX document.
Given that the XLSX is correct when they upload the file ...
Shepherd
Background
Security Considerations
Required per CM-4.
Process checklist
# Sketch [comment]: # "Notes or a checklist reflecting our understanding of the selected approach" [The Figma mocks for the page](https://www.figma.com/file/1bNncVt1TcFFDhQslqFC2o/FAC-Playground?node-id=4954-23338&t=azeQNyHI1V1Ll58h-4). - [ ] Design designs all the things - [ ] Engineering engineers all the things # Definition of Done ## Triage ### If not likely to be important in the next quarter... - [ ] Archived from the board ### Otherwise... - [ ] Has a clear story statement - [ ] Design or Engineering accepts that it belongs in their respective backlog ## Design Backlog - [ ] Has clearly stated/testable acceptance criteria - [ ] Meets the design Definition of Ready [citation needed] - [ ] A design shepherd has been identified ## Design In Progress - [ ] Meets the design Definition of Done [citation needed] ## Design Review Needed - [ ] Necessary outside review/sign-off was provided ## Design Done - [ ] Presented in a sprint review - [ ] Includes screenshots or references to artifacts ### If no engineering is necessary - [ ] Tagged with the sprint where it was finished - [ ] Archived ## Engineering Backlog - [ ] Has clearly stated/testable acceptance criteria - [ ] Has a sketch or list of tasks - [ ] Can reasonably be done in a few days (otherwise, split this up!) ## Engineering Available - [ ] There's capacity in the `In Progress` column - [ ] An engineering shepherd has been identified ## Engineering In Progress - [ ] Meets acceptance criteria - [ ] Meets [QASP conditions](https://derisking-guide.18f.gov/qasp/) ### If there's UI... - [ ] Screen reader - Listen to the experience with a screen reader extension, ensure the information presented in order - [ ] Keyboard navigation - Run through acceptance criteria with keyboard tabs, ensure it works. - [ ] Text scaling - Adjust viewport to 1280 pixels wide and zoom to 200%, ensure everything renders as expected. Document 400% zoom issues with USWDS if appropriate. ## Engineering Blocked - [ ] Blocker removed/resolved ## Engineering Review Needed - [ ] Outside review/sign-off was provided ## Engineering Done - [ ] Presented in a sprint review - [ ] Includes screenshots or references to artifacts - [ ] Tagged with the sprint where it was finished - [ ] Archived