GSA-TTS / cg-egress-proxy

Provides controlled egress for apps in a restricted-egress cloud.gov space
Other
12 stars 4 forks source link

Specify cflinuxfs4 in the proxy manifest #26

Closed rahearn closed 1 year ago

rahearn commented 1 year ago

I'm not convinced this is good to merge into main, but I figured I'd open the PR in case anyone else wants to use this branch until May 10. Or if the group decides that it should be merged after all.

rahearn commented 1 year ago

@mogul are you in favor of merging this into main for long-term use? I'm 50/50 on whether I prefer having the stack explicitly given vs. relying on defaults outside of this transition time.

mogul commented 1 year ago

Same. I am going to use the stack migration CLI plugin on the FAC project because I don't want to hardcode it there, so I guess I wouldn't do it here if it was solely up to me... 🤷‍♂️

rahearn commented 1 year ago

I'm going to merge at COB today if I haven't heard any vetos before then. Worst case we can always delete that line after May 10.

rahearn commented 1 year ago

Keeping that branch around for a bit because at least 2 deploy pipelines are relying on it. Will clean it up by June 1.