mogul
commented
3 years ago I'd like to come up with some stable identifier that gets injected by the Makefile that doesn't change, but I haven't come up with anything good for that yet. I guess I could make it a required env var, and then use the gitref for the value in a GitHub Action... 🤔 needs more thought.
OK, this is my solution... It leverages the default behavior for the cluster_name to:
- ...make it unlikely an individual dev will ever collide with anyone but themself (and they can set the INSTANCE_NAME env var in that case)
- ...make it impossible for different GitHub Action runs to collide.
- ...make it easy to determine which resources were created under particular contexts in AWS.
I tested this one by setting a value for "cluster_name" in the examples. However, I didn't commit that change because if I do, then every instance of the tests running (dev's local code, various GitHub commits being tested in parallel) will all collide with each other.
I'd like to come up with some stable identifier that gets injected by the Makefile that doesn't change, but I haven't come up with anything good for that yet. I guess I could make it a required env var, and then use the gitref for the value in a GitHub Action... 🤔 needs more thought.