search

GSA-TTS / datagov-brokerpak-eks

Broker AWS EKS instances using the OSBAPI (eg from cloud.gov)
Other
9 stars 7 forks source link

Avoid overlong LB names #76

Closed mogul closed 2 years ago

mogul commented 2 years ago

This PR fixes the problem where instances provisioned via the SSB time out while waiting for the ingress-nginx service to get an external IP.

As I mentioned in Slack:

...we've been bitten by this kind of thing before. I think we should alter our tests to use a 64-character instance ID so we'll find these problems before accepting PRs, rather than only after a long deployment process to get it in use by the SSB.

Feel free to make that change yourself before accepting this PR, or wait for me to do it tomorrow... Otherwise we can do it in another PR. I just need to get to bed now and wanted to get this in flight for the east-coast morning crew!

mogul commented 2 years ago

Tests are failing. I saw this when I ran them locally too. Something to do with the CSB 0.5.1 upgrade maybe...?