Closed nickumia-reisys closed 2 years ago
@nickumia-reisys I've tested all of this from my local machine and it's working fine. However it seems like the $planid variable isn't populating under GitHub Actions, and I don't know why. Super weird, because it clearly works if I run make check-ids
locally. Have any ideas?
OK, looks like it was only working locally because I had previous set serviceid
and planid
in my shell when I was testing... When I unset them and run make check-ids
then I'm getting the same result as GitHub Actions. This means those env vars are not properly getting propagated between the lines where they're eval'd and the following lines.
The next step is to get make build up
in a fresh shell where only the AWS creds are set, then fiddle with make check-ids
to figure out something that works. I suspect this is going to mean turning the steps for each target into one long &&-compounded line.
Too tired to continue... Take a look and I will pick this up in the morning if you haven't!
There's no reason that test should have failed to provision because it provisions locally for me just fine. It still has issues being destroyed, but that's not why the test failed either..
In case kubenetes tries to create the storage class before the cluster is actually functional (i.e. node groups coming up or some other race condition), wait until we know the cluster is more ready
Related to,