search

GSA-TTS / datagov-brokerpak-eks

Broker AWS EKS instances using the OSBAPI (eg from cloud.gov)
Other
9 stars 7 forks source link

Allow for multiple levels of subdomain in the certificate #95

Closed mogul closed 2 years ago

mogul commented 2 years ago

Some Helm charts might deploy services multiple subdomains deep. This change just adds SANs with additional levels of wildcarding to allow for that possibility.

(Discovered when we did a Helm install of the GitLab chart... This was literally the only thing we ran into!)

mogul commented 2 years ago

Although the spec and anecdotal evidence say this is supported, AWS Certificate Manager only supports a single level of wildcards. Closing!