PDF generation & navigation not yet working as expected

[jimmoffet]

Overview

As a form filler I get errors when forms aren't complete, I get a sensible success message on submit when it is complete. I can use the next back buttons to navigate form pages. As a form builder I can do the same things in preview mode.

Context

Optional: Any reference material or thoughts we may need for later reference, or assumptions of prior or future work that's out of scope for this story.

• [ ]

Acceptance Criteria

Required outcomes of the story

• [x] Filler and builder users can navigate forms pages, submit and get sensible success fail messages
• [x] Submit form and get complete docs package, if incomplete get an appropriate error
• [ ] ~Keep a record of that form submission, logged with user entered data so that forms service admin can view completed submissions~

Research Questions

• Optional: Any initial questions for research

Tasks

Research, design, and engineering work needed to complete the story.

• [ ] Test with multiple Pardon forms and at least one non-pardon form

Definition of done

The "definition of done" ensures our quality standards are met with each bit of user-facing behavior we add. Everything that can be done incrementally should be done incrementally, while the context and details are fresh. If it’s inefficient or “hard” to do so, the team should figure out why and add OPEX/DEVEX backlog items to make it easier and more efficient.

• [ ] Behavior
  • [ ] Acceptance criteria met
  • [ ] Implementation matches design decisions
• [ ] Documentation
  • [ ] ADRs (/documents/adr folder)
  • [ ] Relevant README.md(s)
• [ ] Code quality
  • [ ] Code refactored for clarity and no design/technical debt
  • [ ] Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies; dependency rule followed
  • [ ] Code is reviewed by team member
  • [ ] Code quality checks passed
• [ ] Security and privacy
  • [ ] Automated security and privacy gates passed
• [ ] Testing tasks completed
  • [ ] Automated tests pass
  • [ ] Unit test coverage of our code >= 90%
• [ ] Build and deploy
  • [ ] Build process updated
  • [ ] API(s) are versioned
  • [ ] Feature toggles created and/or deleted. Document the feature toggle
  • [ ] Source code is merged to the main branch

Decisions

• Optional: Any decisions we've made while working on this story

[JennyRichards-Flexion]

2 open PRs, hoping to be closed out soon in sprint 11. 1st is ready to go, the second is about the 2nd confirmation page. (confirmation page follow-up item is here: https://github.com/GSA-TTS/atj-platform/issues/357)

You will have to submit another form and get a response back.

[JennyRichards-Flexion]

Expect this to take less than a day to complete, plus reviews and subsequent changes.