GSA-TTS / forms

Friendly government forms for everyone.
https://federalist-9ab3a388-1535-4bd5-a4bf-04c7933172d6.sites.pages.cloud.gov/site/gsa-tts/forms/
7 stars 1 forks source link

Multiple Entries component #310

Open jimmoffet opened 2 months ago

jimmoffet commented 2 months ago

Overview

As a form builder, I would like provide an input that allows the user to enter an undetermined number of input fields, so that I can collect information where the answers might vary from person-to-person (e.g. job history over the last 7 years, residential addresses, education, dependent info, etc).

Context

Optional: Any reference material or thoughts we may need for later reference, or assumptions of prior or future work that's out of scope for this story.

Acceptance Criteria

Required outcomes of the story

Research Questions

Tasks

Research, design, and engineering work needed to complete the story.

Definition of done

The "definition of done" ensures our quality standards are met with each bit of user-facing behavior we add. Everything that can be done incrementally should be done incrementally, while the context and details are fresh. If it’s inefficient or “hard” to do so, the team should figure out why and add OPEX/DEVEX backlog items to make it easier and more efficient.

Decisions

Early image of UI for reference and designer reference:

Image

ethangardner commented 2 months ago

Possible inspiration - https://www.advancedcustomfields.com/resources/repeater/.

JennyRichards-Flexion commented 1 month ago

Functionally done but the tests are not good on the user-facing side. Next thing - testing type of thing for accessibility and E2E testing. Tests for this item do not apply to other components.

jimmoffet commented 4 weeks ago

@ethangardner Is this blocked on enhanced tests or do we need to wait for the javascript-blocked handling mentioned in the PR before merging?

Can we merge this and create a new ticket for enhancements, better tests?

ethangardner commented 3 weeks ago

@jimmoffet The tests aren't the reason for the hold up. Those are fine. It's blocked because there were comments in the code review that Dan left for me that he believes might be solved by the form submission branch he's working on. I am in the middle of code review on his branch, and once his changes are in main, we'll pair on the integration work to see if that solves both issues.

jimmoffet commented 4 days ago

Here's the current PR that would close this ticket #336