search

GSA-TTS / touchpoints-site

Touchpoints product website
https://touchpoints.digital.gov
3 stars 3 forks source link

replaced anchor with Identifier component to increase compliance score #90

Closed nick-mon1 closed 2 years ago

nick-mon1 commented 2 years ago

See https://trello.com/c/IOcqaaRQ for details

ryanwoldatwork commented 2 years ago

current state

current-state

future state (after this PR)

future-state

ryanwoldatwork commented 2 years ago

@nick-mon1, @mejiaj, @afeijoo

I saw USWDS was upgraded. Typically, npm start is run to copy all the assets. 1. is that still necessary, and 2. the command is failing due to an error in gulpfile.js. Any ideas?

nick-mon1 commented 2 years ago

@ryanwoldatwork,

If you are using node version 14 you will get this error TypeError: paths.src.fonts.replaceAll is not a function. I'm able to run npm start to completion with node version 16.14.2.

Console error with node version 14

gulp copyAssets [17:03:47] Using gulpfile ~/Documents/gsa/touchpoints-site/gulpfile.js [17:03:47] Starting 'copyAssets'... [17:03:47] Starting 'fonts'... [17:03:47] Starting 'images'... [17:03:47] Starting 'js'... Copying USWDS fonts to ./assets/uswds/fonts [17:03:47] 'fonts' errored after 1.07 ms [17:03:47] TypeError: paths.src.fonts.replaceAll is not a function at fonts (/Users/nlyons/Documents/gsa/touchpoints-site/node_modules/@uswds/compile/gulpfile.js:91:43) at bound (domain.js:421:15) at runBound (domain.js:432:12) at asyncRunner (/Users/nlyons/Documents/gsa/touchpoints-site/node_modules/async-done/index.js:55:18) at processTicksAndRejections (internal/process/task_queues.js:77:11) [17:03:47] 'copyAssets' errored after 2.52 ms npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! uswds-sandbox@ uswds-copy-assets: gulp copyAssets npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the uswds-sandbox@ uswds-copy-assets script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.