Inspector posting to public channels

GSA-TTS / tts-tech-operations

Home of the TTS Technology Portfolio team

https://handbook.tts.gsa.gov/tech-operations/

Other

5 stars 0 forks source link

Inspector posting to public channels #948

Closed afeld closed 1 month ago

afeld commented 3 years ago

Background Information

There's logic that should prevent this from happening:

https://github.com/18F/tts-tech-portfolio/blob/c36975b7136248cc3b9f1ab7c5ad159034a9aec1/inspector/pr-nudges.js#L63-L64

but that doesn't seem to have prevented a message getting posted to #identity-public.

Implementation Steps

Acceptance Criteria

[ ] A dry run shows no messages being posted to -public channels

afeijoo commented 3 years ago

A message was posted to #uswds-public on Saturday.

afeijoo commented 3 years ago

A message was posted to #uswds-public on Saturday.

its-a-lisa-at-work commented 3 years ago

I looked into this a little bit over the weekend and took notes; going to take my name off of it for now and move it out of In Progress and let someone else take a shot at it