search

GSA-TTS / tts.gsa.gov

Making the website work for people who make websites work
https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/staging/
Other
5 stars 3 forks source link

Refactor around GHA and npm pinning #154

Closed wesley-dean-gsa closed 1 month ago

wesley-dean-gsa commented 1 month ago

This pins a few missing GitHub Actions dependencies and instructs the Pa11y workflow to grab the dedDepenedencies (which includes pa11y-ci).

security considerations

This ought to resolve the remaining warnings about unpinned dependencies.

github-actions[bot] commented 1 month ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.06s
⚠️ CSS scss-lint 2 1 2.97s
✅ JAVASCRIPT prettier 6 0 0 1.11s
✅ JSON jsonlint 7 0 0.21s
✅ JSON npm-package-json-lint yes no 0.5s
✅ JSON prettier 7 0 0 1.53s
✅ JSON v8r 7 0 10.49s
✅ MARKDOWN markdownlint 20 0 0 2.07s
✅ MARKDOWN markdown-link-check 20 0 11.99s
✅ MARKDOWN markdown-table-formatter 20 0 0 0.39s
✅ REPOSITORY checkov yes no 15.79s
✅ REPOSITORY gitleaks yes no 0.3s
✅ REPOSITORY git_diff yes no 0.23s
⚠️ REPOSITORY grype yes 2 14.49s
✅ REPOSITORY secretlint yes no 2.66s
⚠️ REPOSITORY trivy yes 1 8.97s
✅ REPOSITORY trivy-sbom yes no 1.65s
✅ REPOSITORY trufflehog yes no 4.16s
⚠️ SPELL cspell 20 1 3.15s
✅ YAML prettier 14 0 0 1.36s
✅ YAML v8r 11 0 13.37s
✅ YAML yamllint 14 0 0.7s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 1 month ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//pin-gha/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//pin-gha/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

• Error: Duplicate id attribute value "svg-bedding" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-bedding └── <... • Error: Duplicate id attribute value "svg-snow" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-snow └──
github-actions[bot] commented 1 month ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//pin-gha/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//pin-gha/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

• Error: Duplicate id attribute value "svg-bedding" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-bedding └── <... • Error: Duplicate id attribute value "svg-snow" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-snow └──
  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.