GSA-TTS / tts.gsa.gov

Making the website work for people who make websites work
https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/staging/
Other
5 stars 3 forks source link

083 update jobs from jointts #156

Closed wesley-dean-gsa closed 2 weeks ago

wesley-dean-gsa commented 1 month ago

Changes proposed in this pull request

-

-

security considerations

[Note the any security considerations here, or make note of why there are none]

github-actions[bot] commented 1 month ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.07s
⚠️ CSS scss-lint 2 1 2.84s
✅ JAVASCRIPT prettier 6 0 0 1.18s
✅ JSON jsonlint 7 0 0.24s
✅ JSON npm-package-json-lint yes no 0.46s
✅ JSON prettier 7 0 0 1.53s
✅ JSON v8r 7 0 10.53s
✅ MARKDOWN markdownlint 21 0 0 2.06s
✅ MARKDOWN markdown-link-check 21 0 13.09s
✅ MARKDOWN markdown-table-formatter 21 0 0 0.39s
✅ REPOSITORY checkov yes no 14.86s
✅ REPOSITORY gitleaks yes no 0.19s
✅ REPOSITORY git_diff yes no 0.14s
⚠️ REPOSITORY grype yes 2 14.28s
✅ REPOSITORY secretlint yes no 2.74s
⚠️ REPOSITORY trivy yes 1 9.2s
✅ REPOSITORY trivy-sbom yes no 1.33s
✅ REPOSITORY trufflehog yes no 4.92s
⚠️ SPELL cspell 21 10 4.16s
✅ YAML prettier 14 0 0 1.33s
✅ YAML v8r 11 0 14.64s
✅ YAML yamllint 14 0 0.66s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 1 month ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//083-update-jobs-from-jointts/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//083-update-jobs-from-jointts/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

• Error: Duplicate id attribute value "svg-bedding" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-bedding └── <... • Error: Duplicate id attribute value "svg-snow" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-snow └──
ximekilgsa commented 3 weeks ago

@wesley-dean-gsa Could you update the branch so it has the latest from main and make sure everything still works as expected? Looks good otherwise!

wesley-dean-gsa commented 3 weeks ago

We may be refactoring how we do this.

wesley-dean-gsa commented 2 weeks ago

This PR is being closed as #83 has been superseded by #165 .