GSA-TTS / tts.gsa.gov

Making the website work for people who make websites work
https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/staging/
Other
5 stars 3 forks source link

148 mobile menu #169

Closed ximekilgsa closed 2 weeks ago

ximekilgsa commented 3 weeks ago

Changes proposed in this pull request

security considerations

None, it's just front-end changes!

github-actions[bot] commented 3 weeks ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.06s
⚠️ CSS scss-lint 2 1 3.08s
✅ JAVASCRIPT prettier 6 0 0 1.22s
✅ JSON jsonlint 7 0 0.22s
✅ JSON npm-package-json-lint yes no 0.48s
✅ JSON prettier 7 0 0 1.48s
✅ JSON v8r 7 0 12.48s
✅ MARKDOWN markdownlint 20 0 0 1.94s
✅ MARKDOWN markdown-link-check 20 0 12.81s
✅ MARKDOWN markdown-table-formatter 20 0 0 0.35s
✅ REPOSITORY checkov yes no 13.83s
✅ REPOSITORY gitleaks yes no 0.34s
✅ REPOSITORY git_diff yes no 0.26s
⚠️ REPOSITORY grype yes 3 13.15s
✅ REPOSITORY secretlint yes no 2.55s
⚠️ REPOSITORY trivy yes 1 7.56s
✅ REPOSITORY trivy-sbom yes no 1.42s
✅ REPOSITORY trufflehog yes no 4.15s
⚠️ SPELL cspell 20 1 3.01s
✅ YAML prettier 14 0 0 1.35s
✅ YAML v8r 11 0 14.13s
✅ YAML yamllint 14 0 0.5s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 3 weeks ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//148-mobile-menu/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//148-mobile-menu/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

• Error: Duplicate id attribute value "svg-bedding" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-bedding └── <... • Error: Duplicate id attribute value "svg-snow" found on the web page. ├── WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 ├── #svg-snow └──
github-actions[bot] commented 3 weeks ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//148-mobile-menu/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//148-mobile-menu/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

1 Errors ```