search

GSA-TTS / tts.gsa.gov

Making the website work for people who make websites work
https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/staging/
Other
5 stars 3 forks source link

Npx check updates try 3 #182

Closed wesley-dean-gsa closed 2 weeks ago

wesley-dean-gsa commented 2 weeks ago

Changes proposed in this pull request

WHhhoooooo. This updates to the latest versions of 11ty and some of its plugins. It includes configuration to allow --legacy-peer-deps, it removes Netlify, and sets a configuration flag so the new 11ty doesn't do weird things with collections.

rm -rf node_modules
npm uninstall netlify-cms
sed -i~ -Ee 's/^\s*(require\s*\("netlify-cms"\);)/\/\/ \1/' js/admin.js
npm install @11ty/eleventy@^3.0.0-beta.1
sed -i~ -Ee '/module.exports\s*=\s*function\s*\(config\)\s*\{\s*/a   config.setFreezeReservedData\(false\);' .eleventy.js
npm config set legacy-peer-deps=true --location=project
git add .eleventy.js _data/assetPaths.json js/admin.js package.json package-lock.json .npmrc
git commit -m "Remove netlify and update 11ty"
git push origin "$(git branch --show-current)"

security considerations

This goes from like 14 findings, some of which were high down to 3 moderate.

github-actions[bot] commented 2 weeks ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.08s
✅ BASH shellcheck 1 0 0.08s
✅ BASH shfmt 1 0 0 0.24s
⚠️ CSS scss-lint 2 1 3.1s
✅ JAVASCRIPT prettier 6 0 0 1.07s
✅ JSON jsonlint 7 0 0.21s
✅ JSON npm-package-json-lint yes no 0.44s
✅ JSON prettier 7 0 0 1.34s
✅ JSON v8r 7 0 12.19s
⚠️ MARKDOWN markdownlint 20 0 10 1.9s
✅ MARKDOWN markdown-link-check 20 0 12.17s
✅ MARKDOWN markdown-table-formatter 20 0 0 0.34s
✅ REPOSITORY checkov yes no 14.17s
✅ REPOSITORY gitleaks yes no 0.29s
✅ REPOSITORY git_diff yes no 0.41s
✅ REPOSITORY grype yes no 13.59s
✅ REPOSITORY secretlint yes no 2.48s
✅ REPOSITORY trivy yes no 7.49s
✅ REPOSITORY trivy-sbom yes no 1.24s
✅ REPOSITORY trufflehog yes no 4.0s
⚠️ SPELL cspell 20 1 2.66s
✅ YAML prettier 14 0 0 1.22s
✅ YAML v8r 11 0 14.81s
✅ YAML yamllint 14 0 0.54s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 2 weeks ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//npx_check_updates_try_3/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//npx_check_updates_try_3/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

1 Errors ```
github-actions[bot] commented 2 weeks ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//npx_check_updates_try_3/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//npx_check_updates_try_3/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

1 Errors ```