search

GSA-TTS / tts.gsa.gov

Making the website work for people who make websites work
https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/staging/
Other
5 stars 3 forks source link

Remove pa11y-ci and use plain ol pa11y #184

Closed wesley-dean-gsa closed 2 weeks ago

wesley-dean-gsa commented 2 weeks ago

Changes proposed in this pull request

Change the pa11y test runner. The old test runner (pa11y-ci) was using an old version of Pa11y and there were issues and PRs for cutting a new release to get around that that have been sitting around for a while and we were using pa11y and not pa11y-ci, so this just cuts out the intermediary.

security considerations

This should resolve an old lodash@4.17.20 pin (we need to be at 4.17.21 or greater)

github-actions[bot] commented 2 weeks ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.08s
✅ BASH shellcheck 1 0 0.09s
✅ BASH shfmt 1 0 0 0.25s
⚠️ CSS scss-lint 2 1 2.96s
✅ JAVASCRIPT prettier 6 0 0 1.01s
✅ JSON jsonlint 7 0 0.2s
✅ JSON npm-package-json-lint yes no 0.49s
✅ JSON prettier 7 0 0 1.28s
✅ JSON v8r 7 0 12.24s
⚠️ MARKDOWN markdownlint 20 0 10 1.94s
✅ MARKDOWN markdown-link-check 20 0 11.83s
✅ MARKDOWN markdown-table-formatter 20 0 0 0.33s
✅ REPOSITORY checkov yes no 14.29s
✅ REPOSITORY gitleaks yes no 0.32s
✅ REPOSITORY git_diff yes no 0.42s
✅ REPOSITORY grype yes no 13.82s
✅ REPOSITORY secretlint yes no 2.82s
✅ REPOSITORY trivy yes no 8.29s
✅ REPOSITORY trivy-sbom yes no 1.09s
✅ REPOSITORY trufflehog yes no 3.9s
⚠️ SPELL cspell 20 1 2.99s
✅ YAML prettier 14 0 0 1.19s
✅ YAML v8r 11 0 15.09s
✅ YAML yamllint 14 0 0.53s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 2 weeks ago
Pa11y testing results ``` Welcome to Pa11y > Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//pa11ytest/ Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//pa11ytest/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. ├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail ├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p └──

For over 50 years, GSA has been...

1 Errors ```