GSA-TTS / usagov-benefits-eligibility

Benefits eligibility estimator tool for USAGov.
22 stars 5 forks source link

Discovery | define content api endpoints #795

Open gchi25 opened 1 year ago

gchi25 commented 1 year ago

Define content API endpoints

This issue is connected to GSA/px-benefit-finder#503, here

scottqueen-bixal commented 1 year ago

This is impacted on where the data will be located as an output of the static build. See comment.

scottqueen-bixal commented 1 year ago

Pending slug updates

EnriqueOrt commented 1 year ago

Waiting on URL Slug updates - clearance on TTS side. Ideally completed before MVP release @erniedeeb to update and provide slugs on this ticket.

Slugs:

erniedeeb commented 1 year ago

Aligned with Diego on using /death for DOLO, which was the big question mark. I'm going to need a bit more time to finalize the directory (e.g. /benefits/death or /benefit-finder/death etc)

erniedeeb commented 1 year ago

We will be using /benefit-finder/death

scottqueen-bixal commented 1 year ago

@gchi25 please see comment above for path usage, we should align our content endpoints if we can with this structure as well.

scottqueen-bixal commented 1 year ago

@fongcindy - A few follow up questions,

Is this going to continue to sit under /benefits/ Government Benefits?

ie. Home > Government Benefits > Benefit Finder > Death or Home > Government Benefits > Death, etc?

What will be present inside of Mobile Menu

Ideally we would want content structure to dictate breadcrumbs and menu items

related: https://github.com/GSA/px-benefit-finder/issues/212 https://github.com/GSA/px-benefit-finder/issues/211

gchi25 commented 1 year ago

The following is a POC for Life Event "Survivor Benefits".

Create Life Event "Survivor Benefits" with Benefit Finder app in this page. Add menu item for this page in Left Menu English under Government benefits.

The "Survivor Benefit" shows up in Government Benefits page. http://localhost/benefits image

Click "Survivor Benefits" link to go to this life event of Benefit Finder app. The Benefit Finder app page has breadcrumb Home > Government benefits > Survivor Benefits image

fongcindy commented 1 year ago

Thanks for creating the POC for survivor benefits. I discussed with Ernie and we plan to keep Home > Government Benefits > Benefit Finder > Death

And the mobile menu should reflect the content structure

gchi25 commented 1 year ago

Implement Benefit Finder menu and breadcrumb.

http://localhost/benefits image

The Benefit Finder card shows up in Government Benefits landing page.

http://localhost/benefit-finder/death image

The breadcrumb shows up in Benefit Finder app page. Home > Government Benefits > Benefit Finder > Death

image

The mobile menu shows up in Benefit Finder app page.

gchi25 commented 1 year ago

To make the following content structure (menu) and breadcrumb,

Home > Benefit Finder > Death,

We need to create a basic page "Benefit Finder". image

gchi25 commented 1 year ago

Implement this in Sandbox.

Navigate to Government Benefits landing page to see Benefit Finder card. Click Benefit Finder card to Benefit Finder landing page. Click Death link to Benefit Finder app.

The breadcrumb and mobile menu work as expected. Breadcrumb: Home > Government Benefits > Benefit Finder > Death Mobile menu:

erniedeeb commented 1 year ago

Looks great, Gene. Can we change the breadcrumb from "Benefit Finder > Death" to "Benefit finder > Death of a loved one"? USAGov uses sentence case in all places.